Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing validation for the InputFormWithLabels sample #5238

Merged
merged 8 commits into from
Jan 25, 2021

Conversation

matthidinger
Copy link
Member

@matthidinger matthidinger commented Jan 6, 2021

Description

Fixes #5201

This sample validation is broken because of the binding expression in the id property. Change the binding such that the id comes from the data as opposed to an if condition.

How Verified

Manually tested on site.
https://adaptivecardsci.z5.web.core.windows.net/pr/5238/samples/InputFormWithLabels.html

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Jan 12, 2021
@ghost ghost assigned almedina-ms Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Hi @paulcam206; Thanks for reviewing this previously stale pull request. Resetting staleness. @matthidinger FYI.

@ghost ghost added the no-recent-activity label Jan 18, 2021
@ghost ghost assigned shalinijoshi19 Jan 18, 2021
@ghost
Copy link

ghost commented Jan 18, 2021

Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jan 18, 2021
@ghost
Copy link

ghost commented Jan 18, 2021

Hi @matthidinger; Thanks for taking action on your previously stale pull request. Resetting staleness.

@ghost ghost added the no-recent-activity label Jan 24, 2021
@ghost ghost assigned RebeccaAnne Jan 24, 2021
@ghost
Copy link

ghost commented Jan 24, 2021

Hi @matthidinger. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jan 25, 2021
@ghost
Copy link

ghost commented Jan 25, 2021

Hi @matthidinger; Thanks for taking action on your previously stale pull request. Resetting staleness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JavsScript ] Required Input validation not working properly on "Input Form with Labels" sample
5 participants