[pic2card] Merging iteration optimization and inclusive condition enhancement. #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haridas
approved these changes
Jan 11, 2021
|
@matthidinger / @paulcam206 Please check the build issue, did multiple retries, didn't help. We would like to make another minor release to pic2card backend service. |
* elements merging iteration optimized and changed generic inclusive conditions * removed old layout method implementations
* Docker build with git hash * Added /version api
|
@paulcam206 The build step "AdaptiveCards-.NET-PR" constantly failing for our PR. The error log can be found here - https://github.com/microsoft/AdaptiveCards/pull/5250/checks?check_run_id=1690139707. Could you please help us to find the root cause of this error. |
|
not entirely sure why this was failing -- for now I've merged this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow