Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Designer] Label the TryNow button with the descriptive text #5257

Merged
merged 5 commits into from
Jan 13, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Jan 11, 2021

Related Issue

ADO 30647822

Description

Marked the "Try Now" button as aria-labelledby the descriptive text.

How Verified

Confirmed locally that narrator now reads the label text in addition to "Try Now"

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jan 11, 2021

Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@RebeccaAnne RebeccaAnne merged commit ffe5040 into main Jan 13, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/trynowbuttonlabel branch January 13, 2021 21:31
@ghost ghost removed the AdaptiveCards v21.01 label Jan 20, 2021
@RebeccaAnne RebeccaAnne added this to the 21.01 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants