Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Remove github button #5264

Merged
merged 4 commits into from
Jan 19, 2021
Merged

[Site] Remove github button #5264

merged 4 commits into from
Jan 19, 2021

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Jan 12, 2021

Related Issue

Fixes VSO 30864551

Description

The github button we had on the landing page for our site didn't meet a11y requirements around keyboard focus, so this rips it out and replaces it with a link.

Old:
image

New:
image

How Verified

  • local build and devtools
Microsoft Reviewers: Open in CodeFlow

Fixes VSO 30864551
@ghost
Copy link

ghost commented Jan 12, 2021

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@ghost ghost removed the AdaptiveCards v21.01 label Jan 13, 2021
@ghost ghost added the no-recent-activity label Jan 18, 2021
@ghost
Copy link

ghost commented Jan 18, 2021

Hi @paulcam206. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jan 19, 2021
@ghost
Copy link

ghost commented Jan 19, 2021

Hi @paulcam206; Thanks for taking action on your previously stale pull request. Resetting staleness.

@paulcam206 paulcam206 merged commit b7b700f into main Jan 19, 2021
@paulcam206 paulcam206 deleted the paulcam/remove-github-badge branch January 19, 2021 15:42
@ghost ghost removed the AdaptiveCards v21.01 label Jan 19, 2021
@ghost ghost removed the AdaptiveCards v21.01 label Jan 20, 2021
@RebeccaAnne RebeccaAnne added this to the 21.01 milestone Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants