Fixed #4739 #4107 #5320
Merged
Fixed #4739 #4107 #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
commented
Jan 23, 2021
| @@ -11,7 +11,7 @@ | |||
| "actions": [ | |||
| { | |||
| "type": "Action.OpenUrl", | |||
| "title": "Action.OpenUrl", | |||
| "title": "long text test, long text test, long text test, long text test, long text test, long text test,long text test", | |||
There was a problem hiding this comment.
I will create a new sample card if we want to have one, otherwise, I will revert this change once the review is over.
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fixed microsoft#4739 microsoft#4107 * complete Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #4739, Fixed #4107
Description
iOS action renderer put horizontal scroll by default as shown in the image.
This behavior is changed to wrap the label when buttons are in vertical orientation via HostConfig.
For horizontal orientation, the renderer will set the width and height of the title label of the button plus the edge insets to be the same as its super view.
Sample Card
TBA.
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow