-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactnative/release 2.2.4 #5324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated version * [ReactNative][Templating] Integrate with AEL in ReactNative Renderer (#4162) * Migrated to AdaptiveCards Templating with AEL Support * Updated README with AEL related changes * updated version details * [ReactNative][Github actions] Github action setup for CI (#4209) * Added simple test case * added basic github actions workflow for testing * Try 1 - fixed path issue * Added proper github actions and included badge in readme * [ReactNative] Changed github action trigger * Reactnative: Label support for all the Input elements. (#4252) * input changes * Completed label property handling in inputs * Resolved package-lock.json conflicts Co-authored-by: Pragadeesh Kanagavel <pragadeesh.kanagavel@imaginea.com>
* Inconsistencies spec (#3633) * First draft of Inconsistencies spec * Categorize bugs, some rewording * Move spec to new location * Add goals * Prioritize action items * Flesh out branching strategy * Add link to @nesalang's iOS inconsistencies talk * Update advice for iOS talk Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> * Added the title in the submit action (#5217) * Added the title in the submit action * Resolved the review comments Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> * Added accessibility support for all adaptive card elements (#5221) * Added the condition fopr handling the maxlength for the input textfield (#5224) Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> * Setting transparent background to container when style is not configured in input json. Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com> Co-authored-by: IbrahimSulai <33604125+IbrahimSulai@users.noreply.github.com> Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> Co-authored-by: Vivek Kozhisseri <vivekvijayakrishnan@gmail.com>
…tton component (#5275) * Added the extensibility for the custom text block component * Added the supportb for the custom action button * Added the supportb for the Image * Updated the comments * Resolved the review comments Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Added the extensibility for the custom text block component * Added the supportb for the custom action button * Added the supportb for the Image * Updated the comments * Resolved the review comments * Added the custom property sample in the payload and handled for custom text block Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Added the extensibility for the custom text block component * Added the supportb for the custom action button * Added the supportb for the Image * Updated the comments * Resolved the review comments * Added the custom property sample in the payload and handled for custom text block * Added the support custom property for all the components * Updated the name of the variable Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Removed the style for the selectaction * updated the version to 2.2.4 * updated the package Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
IbrahimSulai
requested review from
BalajiR,
Vasanth-S,
pragadeeshk and
vivekvijayakrishnan
January 27, 2021 04:32
…o reactnative/release-2.2.4
…oft/AdaptiveCards into reactnative/release-2.2.4
vivekvijayakrishnan
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pragadeeshk
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR consist of the below implementatiuon,
Microsoft Reviewers: Open in CodeFlow