Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactnative/release 2.2.4 #5324

Merged
merged 13 commits into from
Jan 28, 2021
Merged

Reactnative/release 2.2.4 #5324

merged 13 commits into from
Jan 28, 2021

Conversation

IbrahimSulai
Copy link
Contributor

@IbrahimSulai IbrahimSulai commented Jan 27, 2021

The PR consist of the below implementatiuon,

  1. Custom property support for all the component
  2. Custom style support for TextBlock, Image, and ActionButton.
  3. Removed validation property and its child properties.
  4. New property added - isRequired and errorMessage property for all the inputs. regex property for Input.Text
Microsoft Reviewers: Open in CodeFlow

* Updated version

* [ReactNative][Templating] Integrate with AEL in ReactNative Renderer (#4162)

* Migrated to AdaptiveCards Templating with AEL Support

* Updated README with AEL related changes

* updated version details

* [ReactNative][Github actions] Github action setup for CI (#4209)

* Added simple test case

* added basic github actions workflow for testing

* Try 1 - fixed path issue

* Added proper github actions and included badge in readme

* [ReactNative] Changed github action trigger

* Reactnative: Label support for all the Input elements. (#4252)

* input changes

* Completed label property handling in inputs

* Resolved package-lock.json conflicts

Co-authored-by: Pragadeesh Kanagavel <pragadeesh.kanagavel@imaginea.com>
* Inconsistencies spec (#3633)

* First draft of Inconsistencies spec

* Categorize bugs, some rewording

* Move spec to new location

* Add goals

* Prioritize action items

* Flesh out branching strategy

* Add link to @nesalang's iOS inconsistencies talk

* Update advice for iOS talk

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Added the title in the submit action (#5217)

* Added the title in the submit action

* Resolved the review comments

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Added accessibility support for all adaptive card elements (#5221)

* Added the condition fopr handling the maxlength for the input textfield (#5224)

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Setting transparent background to container when style is not configured in input json.

Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Co-authored-by: IbrahimSulai <33604125+IbrahimSulai@users.noreply.github.com>
Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
Co-authored-by: Vivek Kozhisseri <vivekvijayakrishnan@gmail.com>
…tton component (#5275)

* Added the extensibility for the custom text block component

* Added the supportb for the custom action button

* Added the supportb for the Image

* Updated the comments

* Resolved the review comments

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Added the extensibility for the custom text block component

* Added the supportb for the custom action button

* Added the supportb for the Image

* Updated the comments

* Resolved the review comments

* Added the custom property sample in the payload and handled for custom text block

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Added the extensibility for the custom text block component

* Added the supportb for the custom action button

* Added the supportb for the Image

* Updated the comments

* Resolved the review comments

* Added the custom property sample in the payload and handled for custom text block

* Added the support custom property for all the components

* Updated the name of the variable

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Removed the style for the selectaction

* updated the version to 2.2.4

* updated the package

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
Copy link
Contributor

@vivekvijayakrishnan vivekvijayakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pragadeeshk pragadeeshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IbrahimSulai IbrahimSulai merged commit 17bdaf5 into main Jan 28, 2021
@IbrahimSulai IbrahimSulai deleted the reactnative/release-2.2.4 branch January 28, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants