Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brought up ANTLR version & AEL #5384

Merged
merged 13 commits into from
Feb 18, 2021
Merged

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Feb 11, 2021

Related Issue

Fixed #5225

Description

  1. Brought up the AEL & ANTLR version to the latest.
    • ANTLR VS tool, no longer works with ANTLR 4.8 and had to include the generated parser to the source.
  2. Update ANTLR grammar to handle nested "

How Verified

How you verified the fix, including one or all of the following:

  1. Added new unit tests
  2. Tested with all unit tests
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Feb 17, 2021
@ghost ghost assigned almedina-ms Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for the one question :)

@ghost ghost removed the no-recent-activity label Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

Hi @paulcam206; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

1 similar comment
@ghost
Copy link

ghost commented Feb 18, 2021

Hi @paulcam206; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

@jwoo-msft jwoo-msft merged commit 968d413 into main Feb 18, 2021
@jwoo-msft jwoo-msft deleted the jwoo/dotnet-template-grammar-update branch February 18, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Antlr4 version 4.8.0
3 participants