Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwoo/ios additional properties #5395

Merged
merged 6 commits into from
Feb 18, 2021
Merged

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Feb 17, 2021

Related Issue

Fixed #5244

Description

  • Added unit tests for additional properties for documentation.
  • Added a null check for JSON::Value & return nil when the Value has an empty array, empty object or null values
  • code clean-up

Sample Card

  • Added a test payload to iOS unit tests

How Verified

How you verified the fix, including one or all of the following:

  1. Unit tests are added
  2. Passed all existing unit tests
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 47c1b86 into main Feb 18, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-additional-properties branch February 18, 2021 19:52
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Updated UnitTest for additional Properties & Updated Additional
Properties return nil when it's empty

* added missing payload & updated reset logic for a unit test

* updated comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Extensibility] Non-existent custom properties are sent as "null"
2 participants