Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5269 #5407

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Fixed #5269 #5407

merged 2 commits into from
Feb 19, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Feb 19, 2021

Related Issue

Fixed #5269

Description

When a column has pixel width, and the columnset has the column as the only column, the columnset will fail to honour the column's width with the AutoLayout of iOS.

Added an empty view to be used as a filler in such a case.

Sample Card

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "body": [
        {
            "type": "Container",
            "style": "emphasis",
            "backgroundImage": "https://messagecardplayground.azurewebsites.net/assets/Mostly%20Cloudy-Background.jpg",
            "minHeight": "400px",
            "items": [
                {
                    "type": "Container",
                    "minHeight": "380px"
                },
                {
                    "type": "ColumnSet",
                    "columns": [
                        {
                            "type": "Column",
                            "width": "180px",
                            "items": [
                                {
                                    "type": "Container",
                                    "style": "accent"
                                }
                            ]
                        }
                    ]
                }
            ]
        }
    ]
}

How Verified

Bad image available in #5269
image

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 285ac90 into main Feb 19, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-column branch February 19, 2021 20:07
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Rendering] Column width is ignored, generates auto layout errors
2 participants