Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5303 #5440

Merged
merged 9 commits into from
Mar 1, 2021
Merged

Fixed #5303 #5440

merged 9 commits into from
Mar 1, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Feb 26, 2021

Related Issue

Fixed #5303

Description

Added additional properties support at the card level for Shared model & iOS

Sample Card

 {
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "card.cornerRadius" : 50.0,
    "body": [
        {
            "type": "Container",
            "items": [
                {
                    "type": "TextBlock",
                    "text": "Test Card",
                    "wrap": true
                }
            ],
            "my.cornerRadius" : 20.0
        }
    ]
}

How Verified

How you verified the fix, including one or all of the following:

  1. Added a new Unit Test to iOS & Shared models.
  2. Ran existing unit tests.
Microsoft Reviewers: Open in CodeFlow

@golddove golddove requested a review from paulcam206 March 1, 2021 17:34
@jwoo-msft jwoo-msft merged commit b9f1cfa into main Mar 1, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-additional-props branch March 1, 2021 20:16
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* work -in progress

* Added Additional Properties at Card level for shared model & ios

* Added Unit Tests

* fixed typo

* changed raw pointer to smart pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Rendering] There's no way to get additional properties from ACOAdaptiveCard
2 participants