Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UWP] Update defaults to meet contrast requirements for destructive buttons #5454

Merged
merged 2 commits into from
Mar 3, 2021
Merged

[UWP] Update defaults to meet contrast requirements for destructive buttons #5454

merged 2 commits into from
Mar 3, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Mar 2, 2021 •
edited

Related Issue

Fixes ADO 31600571

Description

Two fixes to improve contrast on destructive buttons:

  1. Update the Attention color in the sample host config and UPW visualizer host config to be of sufficient contrast against the default button background.
  2. Update logic that sets hover color to make the color darker rather than lighter. This increases the contrast on hover rather than decreasing it.

Sample Card

ExpenseReport.json

How Verified

Confirmed button meets contrast requirements both when hovered and when not hovered:

Button:

image

Non-hover contrast:

image

Hover contrast:

image

Microsoft Reviewers: Open in CodeFlow

@RebeccaAnne RebeccaAnne merged commit 7596517 into main Mar 3, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/hoverContrast branch March 3, 2021 18:12
@golddove golddove added this to the 21.03 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
21.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RebeccaAnne @paulcam206 @golddove