[JS] Fix broken column separator rendering #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [JS][Site][Designer][Pic2card] Update node package dependencies * Update package-lock.json
golddove
approved these changes
Mar 2, 2021
dclaux
added a commit
that referenced
this pull request
Mar 3, 2021
* [.NET] Update Xceed licensing (#5443) * [JS][Site][Designer][Pic2card] Update node package dependencies (#5442) * [JS][Site][Designer][Pic2card] Update node package dependencies * Update package-lock.json * [UWP] Update Media elements to set the altText as the automation name on the button (#5448) * [JS] Fix broken column separator rendering (#5457) * [.NET] Update Xceed licensing (#5443) * [JS][Site][Designer][Pic2card] Update node package dependencies (#5442) * [JS][Site][Designer][Pic2card] Update node package dependencies * Update package-lock.json * Fix broken separator rendering in Column Co-authored-by: Paul Campbell <paulcam@microsoft.com> * Audit * Revert "Merge branch 'main' into 21.02/audit" This reverts commit dc1a8a5, reversing changes made to 4cc85fd. Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5455
Description
For the last few releases (since October 2020 at least) Column separator rendering has been broken, with the separator lacking spacing on the right of the separation line. This was due to some logic designed for horizontal separators being applied to the a Column's vertical separator.
Sample Card
Find sample card in issue linked above
How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow