Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS]Updated action registration API #5527

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Mar 9, 2021

Related Issue

Fixed #5271

Description

the method that overrides default actions renderers take NSNumber as a key, it's very cumbersome to use in Swift & it's not intuitive to use. Changed it to use enum type for the default renderers.

How Verified

  1. Updated sample app to use the new method.
  2. Added a new unit test.
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 5f566cb into main Mar 10, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-register-update branch March 10, 2021 01:22
jwoo-msft added a commit that referenced this pull request Apr 8, 2021
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Framework] ACRRegistration.setActionRenderer() takes an opaque NSNumber instead of an enum
2 participants