Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] Accessibility changes to pic2card dialog #5532

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Mar 10, 2021

Related Issue

Fixes VSO #30650186

Description

After pic2card converts an image, we need to provide feedback to the user that the conversion was successful. While I was in here, I made a couple changes to manage focus.

How Verified

  • local build, devtools, narrator
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Mar 10, 2021

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 added Area-Accessibility Bugs around feature accessibility Area-Designer labels Mar 10, 2021
@paulcam206 paulcam206 enabled auto-merge (squash) March 11, 2021 15:57
@paulcam206 paulcam206 merged commit f9c3169 into main Mar 11, 2021
@paulcam206 paulcam206 deleted the paulcam/pic2card-aria-notifications branch March 11, 2021 16:15
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Designer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants