Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pic2card broken gif url fix #5535

Merged
merged 1 commit into from
Mar 11, 2021
Merged

pic2card broken gif url fix #5535

merged 1 commit into from
Mar 11, 2021

Conversation

haridas
Copy link
Contributor

@haridas haridas commented Mar 11, 2021

The asset's raw URL was relative to the feature branch instead of the main branch.

Microsoft Reviewers: Open in CodeFlow

The asset's raw URL was relative to the feature branch instead of the main branch.
@haridas haridas requested a review from Vasanth-S March 11, 2021 03:08
@ghost
Copy link

ghost commented Mar 11, 2021

Hi @haridas. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@Vasanth-S Vasanth-S merged commit 8dfcf1c into main Mar 11, 2021
@Vasanth-S Vasanth-S deleted the pic2card-broken-url-fix branch March 11, 2021 05:20
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
The asset's raw URL was relative to the feature branch instead of the main branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants