[dotnet] Added AEL simple object memory interface #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Mar 12, 2021
| private SimpleObjectMemory simpleObjectMemory; | ||
| /// <summary> | ||
| /// Simple implementation of AEL.Memory.IMemory | ||
| /// It serves as an entry points to additional customazation and optimazation |
There was a problem hiding this comment.
minor nit
Suggested change
| /// It serves as an entry points to additional customazation and optimazation | |
| /// It serves as an entry points to additional customization and optimization |
There was a problem hiding this comment.
Thanks, Paul. PR got auto merged. I will make this change.
jwoo-msft
added a commit
that referenced
this pull request
Apr 8, 2021
* Fixed issue #4164 * [dotnet] Added Simple Memory Interface * fixed the typo for comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5518
Description
Expansion of the template is done in the context of serialized json payload,
However, the memory that bounds to the template are in deserialized form.
In the previous implementation, we serialized the expanded string returned from AEL. This can lead to double serialization as observed in #5518. Only data that is bound to the template is serialized, and the template portion is left untouched in the new implementation.
How Verified
Microsoft Reviewers: Open in CodeFlow