Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactnative/release 2.2.6 #5564

Merged
merged 5 commits into from
Mar 19, 2021
Merged

Reactnative/release 2.2.6 #5564

merged 5 commits into from
Mar 19, 2021

Conversation

IbrahimSulai
Copy link
Contributor

@IbrahimSulai IbrahimSulai commented Mar 19, 2021 •
edited by ghost

This PR for the release-2.2.6 contains the below changes:

  1. Upgraded the react-native version to the latest stable version - 0.63.4
  2. Picker component migrated to - @react-native-picker/picker
  3. DatePickerIOS component migrated to - @react-native-community/datetimepicker
  4. DatePickerAndroid component migrated to - @react-native-community/datetimepicker
  5. TimePickerAndroid component migrated to - @react-native-community/datetimepicker
  6. componentWillReceiveProps() state is migrated and handled in getDerivedStateFromProps()
  7. componentWillMount() state is migrated and handled in the constructor()
  8. Handled the unknown and fallback element
  9. Handled the spacing and separator style
  10. Handled the height property at the adaptive card root level
Microsoft Reviewers: Open in CodeFlow

IbrahimSulai and others added 4 commits March 1, 2021 14:16
@IbrahimSulai
Upgraded the react native version to latest stable version - 0.63.4 (#…
5abe564 
…5414)

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
@IbrahimSulai
Migrated the deprecated and warning packages (#5522)
0b053a8 
Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
@IbrahimSulai
Handled the unknown and fallback element (#5536)
89ded47 
* Handled the unknown and fallback element, Separator and spacing style handled as per the schema

* Added the condition for creating separator and spacing

* Resolved the review comment

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
@IbrahimSulai
Reactnative/handle unknown element (#5547)
0044991 
* Handled the unknown and fallback element, Separator and spacing style handled as per the schema

* Added the condition for creating separator and spacing

* Resolved the review comment

* Handled the height property at the adaptive card root level

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
vivekvijayakrishnan
vivekvijayakrishnan approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@vivekvijayakrishnan vivekvijayakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IbrahimSulai IbrahimSulai merged commit eadd1ca into main Mar 19, 2021
@IbrahimSulai IbrahimSulai deleted the reactnative/release-2.2.6 branch March 19, 2021 10:45
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@IbrahimSulai @michaelfarnsworth
Reactnative/release 2.2.6 (microsoft#5564)
48bd71b 
* Upgraded the react native version to latest stable version - 0.63.4 (microsoft#5414)

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Migrated the deprecated and warning packages (microsoft#5522)

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Handled the unknown and fallback element (microsoft#5536)

* Handled the unknown and fallback element, Separator and spacing style handled as per the schema

* Added the condition for creating separator and spacing

* Resolved the review comment

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Reactnative/handle unknown element (microsoft#5547)

* Handled the unknown and fallback element, Separator and spacing style handled as per the schema

* Added the condition for creating separator and spacing

* Resolved the review comment

* Handled the height property at the adaptive card root level

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekvijayakrishnan vivekvijayakrishnan vivekvijayakrishnan approved these changes

@Vasanth-S Vasanth-S Awaiting requested review from Vasanth-S

@pragadeeshk pragadeeshk Awaiting requested review from pragadeeshk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IbrahimSulai @vivekvijayakrishnan