Merge RTL feature branch to main #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard
* [JS] Handle explicit rtl: false * Test cards * PR feedback
* [iOS] added RTL support * [iOS] few updates * [iOS] fixed samples
… support (#5581) * Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard * SWIG, Android RTL * Re-SWIG after rebase * FactSet alignment * ImageSet order, alignment
* [Schema] Add RTL property to schema * Change "1.5" to "vNext" * Update type to be nullable and provided more detailed description of behavior
|
Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Shared] Rtl support (microsoft#5578) * Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard * [JS] Handle explicit rtl: false (microsoft#5589) * [JS] Handle explicit rtl: false * Test cards * PR feedback * [UWP] Add RTL support to UWP (microsoft#5600) * [iOS] added RTL support (microsoft#5604) * [iOS] added RTL support * [iOS] few updates * [iOS] fixed samples * [.NET] Add RTL support to WPF renderer (microsoft#5611) * [Android] Improve right-to-left locale support, add rtl override flag support (microsoft#5581) * Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard * SWIG, Android RTL * Re-SWIG after rebase * FactSet alignment * ImageSet order, alignment * [Schema] Add RTL property to schema (microsoft#5616) * [Schema] Add RTL property to schema * Change "1.5" to "vNext" * Update type to be nullable and provided more detailed description of behavior * Updated specs Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [Shared] Rtl support (microsoft#5578) * Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard * [JS] Handle explicit rtl: false (microsoft#5589) * [JS] Handle explicit rtl: false * Test cards * PR feedback * [UWP] Add RTL support to UWP (microsoft#5600) * [iOS] added RTL support (microsoft#5604) * [iOS] added RTL support * [iOS] few updates * [iOS] fixed samples * [.NET] Add RTL support to WPF renderer (microsoft#5611) * [Android] Improve right-to-left locale support, add rtl override flag support (microsoft#5581) * Squash + resolve conflicts * Refactor RTL to only apply to Container, Column, AdaptiveCard * SWIG, Android RTL * Re-SWIG after rebase * FactSet alignment * ImageSet order, alignment * [Schema] Add RTL property to schema (microsoft#5616) * [Schema] Add RTL property to schema * Change "1.5" to "vNext" * Update type to be nullable and provided more detailed description of behavior * Updated specs Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow