[Android] Remove Markdown processing from TextRun, and fix default font #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Run defaulting to monospace
paulcam206
approved these changes
Apr 14, 2021
RebeccaAnne
approved these changes
Apr 15, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…nt (microsoft#5662) * [Android] Remove Markdown processing from RichTextBlock, and fix TextRun defaulting to monospace * Added test card
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…nt (microsoft#5662) * [Android] Remove Markdown processing from RichTextBlock, and fix TextRun defaulting to monospace * Added test card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4914
Description
RichTextBlock's TextRuns were going through Markdown processing, causing inconsistencies with the JS renderer (e.g. in the filed issue, leading/trailing newlines are trimmed). This PR removes that call for TextRun.
Additionally, this fixes TextRun erroneously defaulting to a monospace font when there is no font family configured.
Sample Card
Added test card
v1.2/Tests/RichTextBlock.Markdown.jsonHow Verified
Microsoft Reviewers: Open in CodeFlow