Reactnative/release 2.2.7 #5690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…execute (#5570) * Implemented the universal action model and Handled the type - action.execute * Resolced the review comment Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Handled HostConfig, StyleConfig and ThemeConfig at Card level * Removed ThemeConfigManager as it's not used * Fixed font issues in host-config
… the condition to avaoid separator for first element (#5622) Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
…as per the web platform working model (#5625) Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
vivekvijayakrishnan
requested review from
Vasanth-S,
pragadeeshk and
IbrahimSulai
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Implemented the universal action model and Handled the type - action.execute (microsoft#5570) * Implemented the universal action model and Handled the type - action.execute * Resolced the review comment Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> * HostConfig, StyleConfig and ThemeConfig at Card level (microsoft#5605) * Handled HostConfig, StyleConfig and ThemeConfig at Card level * Removed ThemeConfigManager as it's not used * Fixed font issues in host-config * Handled the padding value as zero in the host configuration and Added the condition to avaoid separator for first element (microsoft#5622) Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> * Handled the cardScrollEnabled property and Aligned the button action as per the web platform working model (microsoft#5625) Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com> * Theme-config extention for radioButton, checkbox and dropdown (microsoft#5644) * Host config spacing changes and removed unused code (microsoft#5689) * updated test snapshot Co-authored-by: IbrahimSulai <33604125+IbrahimSulai@users.noreply.github.com> Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note
1. Universal Action Model - Spec
Support for Universal action model and handled the type -
Action.Execute2. HostConfig, StyleConfig and ThemeConfig at Card level
HostConfig, StyleConfig, and ThemeConfig are handled at the Adaptive Card level instead of for a particular host application. This enables developers to use different configs for each card rather than one set of configs for a host.
3. Theme Config Update
Extended theme config support for
Input.ChoiceSet* Below properties are supported for each type.✅ RadioButton
radioButton- Accept react-native supported styles for<Image>componenent.radioButtonText- Accept react-native supported styles for<Text>component.✅ Checkbox
checkBox- Accept react-native supported styles for<Image>componenent.checkBoxText- Accept react-native supported styles for<Text>component.Apart from react-native styles, the above properties are consumed extra params named
activeColorandinactiveColorto control the clicked and unclicked items.✅ DropDown
dropdown- Accept react-native supported styles for<View>componenent.dropdownText- Accept react-native supported styles for<Text>component.4 Introduced new property to handle the adaptive card Scroll Enabled property
5 Aligned the button action items as per the Web Platform working model
6 Handled the padding value as zero in the host configuration
7 Added the condition to avoid separator for the first element
Microsoft Reviewers: Open in CodeFlow