[iOS][ColumnSet] ChoiceSet inside ColumnSet has improper layout #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akaashdev
changed the title
jwoo-msft
reviewed
Apr 20, 2021
| @@ -61,7 +61,7 @@ - (UIView *)render:(UIView<ACRIContentHoldingView> *)viewGroup | |||
| } | |||
|
|
|||
| // removes leading padding | |||
| choiceSetView.contentInset = UIEdgeInsetsMake(0, -15, 0, 0); | |||
| choiceSetView.contentInset = UIEdgeInsetsMake(0, 0, 0, 0); | |||
There was a problem hiding this comment.
nit: can you remove this line?
|
@akaashdev |
|
Yea that's right @jwoo-msft. It didn't cause any layout conflicts as far as I tested and it didn't cause any overlaps. |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5399
Description
layoutSubviewslifecycle methodSample Card
{ "type": "AdaptiveCard", "body": [ { "type": "TextBlock", "text": "Choose specific types:", "wrap": true }, { "type": "ColumnSet", "columns": [ { "type": "Column", "width": "stretch", "items": [ { "type": "Input.ChoiceSet", "choices": [ { "title": "Full-time", "value": "1" }, { "title": "Hourly", "value": "2" }, { "title": "Agency", "value": "3" } ], "placeholder": "Please choose employee type (All, Ford, or Agency)", "id": "employee_1", "isMultiSelect": true, "style": "expanded", "value": "0", "wrap": true } ] }, { "type": "Column", "width": "stretch", "items": [ { "type": "Input.ChoiceSet", "choices": [ { "title": "Joint Venture", "value": "4" }, { "title": "Part-time", "value": "5" }, { "title": "New Employee", "value": "6" } ], "placeholder": "Please choose employee type", "isMultiSelect": true, "id": "employee_2", "wrap": true } ] }, { "type": "Column", "width": "stretch", "items": [ { "type": "Input.ChoiceSet", "choices": [ { "title": "Subsidiary", "value": "7" }, { "title": "Supplier", "value": "8" } ], "placeholder": "Placeholder text", "isMultiSelect": true, "id": "employee_3" } ] } ] } ], "$schema": "http://adaptivecards.io/schemas/adaptive-card.json", "version": "1.3", "actions": [ { "type": "Action.Submit", "title": "Submit", "style": "positive", "id": "submit" } ] }How Verified
Before fix
After fix
Microsoft Reviewers: Open in CodeFlow