[JS] Table element #5705

dclaux · 2021-04-21T18:20:55Z

Related Issue

Implements [JS] Table Implementation #5729
Also introduces a new "adaptivecards-extras" package

Description

Adds support for the Table element (spec: Table element spec and design review #5630) to the JS SDK.
Introduces the "adaptivecards-extras" package
- This package is designed to include additional AC features for the JS SDK
- These features will be either demos, documentation samples, experiments or preview features destined to be eventually integrated in the main SDK
- None of the features in this package are fully tested nor supported. They might change or even be removed without notice
- With this PR, the package only contains an implementation of an Extras.ProgressBar custom element, which we have so far used as a sample for creating custom elements.
- Refer to the README.md file for more details
Introduces the "adaptivecards-extras-designer" package
- This package implements designer support for features exported by the "adaptivecards-extras" package
- Refer to the package's README.md for more information

Microsoft Reviewers: Open in CodeFlow

- ac-typed-schema@0.6.0 - aclint@0.2.0 - adaptivecards-controls@0.7.0 - adaptivecards-designer-app@0.5.2 - adaptivecards-designer@2.1.0 - adaptivecards-extras-testapp@0.1.1 - adaptivecards-extras@0.1.1 - adaptivecards-fabric@1.1.2 - adaptivecards-site@0.7.0 - adaptivecards-templating@2.1.0 - adaptivecards-visualizer@1.3.2 - adaptivecards@2.8.0 - marked-schema@0.1.7 - spec-generator@0.6.1

ghost · 2021-04-21T18:21:00Z

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

ghost · 2021-04-26T20:00:18Z

Hi @dclaux. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

ghost · 2021-04-26T22:03:37Z

Hi @dclaux; Thanks for taking action on your previously stale pull request. Resetting staleness.

ghost · 2021-05-05T20:00:14Z

Hi @dclaux. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

ghost · 2021-05-07T16:30:06Z

Hi @dclaux; Thanks for taking action on your previously stale pull request. Resetting staleness.

source/nodejs/adaptivecards-designer/src/card-designer-surface.ts

source/nodejs/adaptivecards-extras-designer/src/adaptivecards-extras-designer.ts

source/nodejs/adaptivecards-extras/src/progress-bar.ts

paulcam206 · 2021-05-10T22:32:00Z

source/nodejs/adaptivecards/src/table.ts

+import { Strings } from "./strings";
+import { stringToCssColor } from "./utils";
+
+export class ColumnDefinition extends SerializableObject {


Feel like this should be TableColumnDefinition to prevent confusion with ColumnSet Columns

I don't really mind, but this is per spec.

If you feel strongly about this one, please send a mail to the team to suggest this name change which would also have to be reflected in the spec that Risheek has a PR for here: #5806

I don't think we need to hold this PR on the conversation, so approving :)

jonmill

Thanks for all the hard work here David, looks good!

Not blocking this time, but in the future could you please break up large changes into smaller packages to review? Large code drops are difficult to properly review, so it'll help get prompter and better feedback in the future. Thank you!

jonmill · 2021-05-11T19:57:43Z

source/nodejs/adaptivecards-designer-app/package.json

-		"adaptivecards": "^2.9.0",
-		"adaptivecards-controls": "^0.8.0",
-		"adaptivecards-designer": "^2.2.0",
+		"adaptivecards": "^2.8.0",


Looks like we're downgrading the Adaptive Cards packages? Or am I reading that incorrectly

Correct. Typically, we should NOT up this dependency version every time we release a new adaptivecards package, unless that package introduces new APIs that are required by the designer. 2.8.0 is a good minimal version to stick to for now.

And... let me contradict myself. The designer has dependencies on the breaking changes we are making to support text styles, so this dependency needs to be pointing to the latest version this time around. I'll update.

source/nodejs/adaptivecards-designer/src/base-tree-item.ts

…into js/extras

* Publish - ac-typed-schema@0.6.0 - aclint@0.2.0 - adaptivecards-controls@0.7.0 - adaptivecards-designer-app@0.5.2 - adaptivecards-designer@2.1.0 - adaptivecards-extras-testapp@0.1.1 - adaptivecards-extras@0.1.1 - adaptivecards-fabric@1.1.2 - adaptivecards-site@0.7.0 - adaptivecards-templating@2.1.0 - adaptivecards-visualizer@1.3.2 - adaptivecards@2.8.0 - marked-schema@0.1.7 - spec-generator@0.6.1 * Initial commit * Working through package hell * End of package hell? * Table - WIP * Table - WIP * Table - WIP * Table - still WIP * Table - almost done * Small bug fix * Fix newly dropped card element initialization * Tweaks * Move to flex, <table> is too constraining * Col header txt style, cascading h and v alignments * Adjust cellSpacing to 8 (4 isn't enough) * Move Table to main package * Add column editing support in designer * Fix treeview ordering issue * Add missing copyright headers * Explicit color variable names in ProgressBar * Rearrange code to fix build break * TableColumnDefinition + pkg version updates

dclaux added 19 commits March 23, 2021 13:07

Initial commit

6fe18b2

Working through package hell

f822545

End of package hell?

8a293b1

Table - WIP

2f4151f

Table - WIP

6a06e18

Table - WIP

73148f9

Merge remote-tracking branch 'origin/release/schema-1.4' into js/extras

7bc0ca3

Table - still WIP

f2ab154

Table - almost done

53b9ece

Small bug fix

deba0ba

Fix newly dropped card element initialization

f3a3461

Tweaks

757ea74

Move to flex, <table> is too constraining

0d97bac

Merge branch 'main' into js/extras

0549ef6

Merge branch 'main' into js/extras

abc4d78

Merge branch 'main' into js/extras

45be695

Col header txt style, cascading h and v alignments

4869ece

Adjust cellSpacing to 8 (4 isn't enough)

b14a861

dclaux mentioned this pull request Apr 21, 2021

Table element spec and design review #5630

Closed

ghost added the no-recent-activity label Apr 26, 2021

Merge branch 'main' into js/extras

6b5388d

ghost removed the no-recent-activity label Apr 26, 2021

dclaux added 2 commits April 29, 2021 15:10

Merge branch 'main' into js/extras

e66cad7

Merge branch 'main' into js/extras

4797629

ghost added the no-recent-activity label May 5, 2021

Merge branch 'main' into js/extras

b845da5

ghost removed the no-recent-activity label May 7, 2021

dclaux added 4 commits May 7, 2021 12:34

Move Table to main package

12423e7

Merge branch 'main' into js/extras

a05a7ed

Add column editing support in designer

a11584d

Merge branch 'main' into js/extras

85323b1

dclaux marked this pull request as ready for review May 10, 2021 20:02

dclaux requested review from paulcam206, matthidinger, golddove, jonmill, jwoo-msft and RebeccaAnne May 10, 2021 20:02

Fix treeview ordering issue

6ced51f

paulcam206 requested changes May 10, 2021

View reviewed changes

ghost added the Needs: Author Feedback label May 10, 2021

Add missing copyright headers

a324298

ghost removed the Needs: Author Feedback label May 10, 2021

Explicit color variable names in ProgressBar

f3693e1

paulcam206 approved these changes May 11, 2021

View reviewed changes

jonmill approved these changes May 11, 2021

View reviewed changes

dclaux added 4 commits May 11, 2021 16:12

Merge branch 'main' into js/extras

b38a1d7

Rearrange code to fix build break

f3b3424

Merge branch 'js/extras' of https://github.com/microsoft/AdaptiveCards …

71c1d1c

…into js/extras

TableColumnDefinition + pkg version updates

ca74409

dclaux merged commit 437e57a into main May 12, 2021

dclaux deleted the js/extras branch May 12, 2021 17:43

Vasanth-S mentioned this pull request Aug 11, 2022

[RN] Add support for Table element BigThinkcode/AdaptiveCards#99

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JS] Table element #5705

[JS] Table element #5705

dclaux commented Apr 21, 2021 •

edited

ghost commented Apr 21, 2021

ghost commented Apr 26, 2021

ghost commented Apr 26, 2021

ghost commented May 5, 2021

ghost commented May 7, 2021

paulcam206 May 10, 2021

dclaux May 10, 2021

dclaux May 10, 2021

paulcam206 May 11, 2021

jonmill left a comment

jonmill May 11, 2021

dclaux May 11, 2021

dclaux May 12, 2021

[JS] Table element #5705

[JS] Table element #5705

Conversation

dclaux commented Apr 21, 2021 • edited

Related Issue

Description

Microsoft Reviewers: Open in CodeFlow

ghost commented Apr 21, 2021

ghost commented Apr 26, 2021

ghost commented Apr 26, 2021

ghost commented May 5, 2021

ghost commented May 7, 2021

paulcam206 May 10, 2021

Choose a reason for hiding this comment

dclaux May 10, 2021

Choose a reason for hiding this comment

dclaux May 10, 2021

Choose a reason for hiding this comment

paulcam206 May 11, 2021

Choose a reason for hiding this comment

jonmill left a comment

Choose a reason for hiding this comment

jonmill May 11, 2021

Choose a reason for hiding this comment

dclaux May 11, 2021

Choose a reason for hiding this comment

dclaux May 12, 2021

Choose a reason for hiding this comment

dclaux commented Apr 21, 2021 •

edited