Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Schema] Schema updates for Heading Styles #5717

Merged
merged 3 commits into from
Apr 27, 2021
Merged

[Schema] Schema updates for Heading Styles #5717

merged 3 commits into from
Apr 27, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Apr 26, 2021 •
edited by ghost

Related Issue

Fixes #5637

Description

  • Updates to Adaptive Cards schema (Adaptive cards schema is generated via a tool from source files in schemas\src)

    • TextBlock properties color, fontType, isSubtle, size, weight, and style are now nullable
    • TextBlock properties color, fontType, isSubtle, size, and weight are now nullable

  • Update Host Config schema

    • Rename TextBlockConfig to FactSetTextConfig
    • Add TextStyleConfig and TextStylesConfig
    • Add FontType to FactSetTextConfig (this should have already been there but was missing)
Microsoft Reviewers: Open in CodeFlow

paulcam206
paulcam206 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RebeccaAnne RebeccaAnne merged commit f6a0a34 into main Apr 27, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/headingstyleschema branch April 27, 2021 16:28
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@michaelfarnsworth
[Schema] Schema updates for Heading Styles (microsoft#5717)
8e39484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Schema] Update schemas for heading styles
2 participants
@RebeccaAnne @paulcam206