[Shared/UWP] Add IsEnabled property to actions #5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaAnne
force-pushed
the
rebecch/uwpisenabled
branch
from
f41cf54
to
99788c1
Compare
added 5 commits
April 27, 2021 08:46
paulcam206
approved these changes
Apr 28, 2021
| @@ -617,9 +625,19 @@ namespace AdaptiveNamespace::ActionHelpers | |||
| ComPtr<IAdaptiveHostConfig> hostConfig; | |||
| THROW_IF_FAILED(renderContext->get_HostConfig(&hostConfig)); | |||
|
|
|||
| if (ActionHelpers::WarnForInlineShowCard(renderContext, action, L"Inline ShowCard not supported for SelectAction")) | |||
| // We don't wrap the element if it's a show card or if the action's not enabled; | |||
| bool dontWrap = ActionHelpers::WarnForInlineShowCard(renderContext, action, L"Inline ShowCard not supported for SelectAction"); | |||
There was a problem hiding this comment.
could we make this shouldWrap -- we should avoid negatives in bools :D
| @@ -90,6 +90,15 @@ namespace AdaptiveNamespace | |||
| return AdaptiveActionElementBase::put_Tooltip(tooltip); | |||
| } | |||
|
|
|||
| IFACEMETHODIMP put_IsEnabled(boolean isEnabled) override | |||
There was a problem hiding this comment.
definitely not something to do in this PR, but I think if we refactor our classes using cppwinrt, we should be able to derive classes in a way that makes it so we can get out of the business of manually calling the base (LinkButton does something similar to this).
guessing it might require breaking API surface changes, so maybe part of our next major rev? just a thought :)
There was a problem hiding this comment.
I agree, I'd love to get more cppwinrt in here. I feel like it shouldn't require breaking changes? But I don't know. Definitely something to work towards at some point.
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Shared] Add IsEnabled to the shared model * [UWP] Add IsEnabled to the object model * [UWP] Renderer Support * PR feedback
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [Shared] Add IsEnabled to the shared model * [UWP] Add IsEnabled to the object model * [UWP] Renderer Support * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5723
Fixes #5721
Description
Add isEnabled property to actions in the shared model and UWP and updated the UWP renderer code to respect it
Sample Card
New sample card added samples\v1.5\Elements\Action.IsEnabled.json
How Verified
Microsoft Reviewers: Open in CodeFlow