Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Update scenario samples to use heading style #5737

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Apr 27, 2021

Related Issue

ADO 29462597

Description

Updates the scenario samples called out in the above ADO bug to use the newly introduced heading style. This will cause it to be reported correctly for accessibility.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@golddove golddove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first textblocks in ActivityUpdate, CalendarReminder, and ExpenseApproval (and their respective *WithLabels versions) look like they should be headings, too, right?

@RebeccaAnne
Copy link
Contributor Author

Good point. I just went for the ones called out in the ADO bug, but I'll update those as well.


In reply to: 646973700

@RebeccaAnne RebeccaAnne merged commit 4888dbb into main Apr 28, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/headingsamples branch April 28, 2021 16:10
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* [Samples] Update scenario samples to use heading style

* Update more samples per PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants