Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate aria-labelledby ids in inputs #5750

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

dclaux
Copy link
Member

@dclaux dclaux commented Apr 29, 2021

Related Issue

Fixes #5686

Description

  • A previous merge caused code that had been moved from one method to another to be exist in both methods. This PR removes the duplicated code.
  • This bug applied to all inputs, not just Input.ChoiceSet

Sample Card

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "body": [
        {
            "type": "Input.Text",
            "placeholder": "Placeholder text",
            "label": "Text input label"
        },
        {
            "type": "Input.ChoiceSet",
            "choices": [
                {
                    "title": "Choice 1",
                    "value": "Choice 1"
                },
                {
                    "title": "Choice 2",
                    "value": "Choice 2"
                }
            ],
            "placeholder": "Placeholder text",
            "label": "ChoiceSet input label"
        }
    ]
}

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Apr 29, 2021

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

Copy link
Contributor

@jonmill jonmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick turnaround

@dclaux dclaux merged commit 64dc268 into main Apr 30, 2021
@dclaux dclaux deleted the js/duplicate-aria-id branch April 30, 2021 01:21
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JS] [Accessibility] Duplicate Ids in aria-labelledby attribute for Input.ChoiceSet
3 participants