[UWP] Add rendering support for tooltip property #5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rendering test since the feature isn't developed for iOS
…iveCards into rebecch/uwptooltiprender
|
Thanks @jwoo-msft! |
paulcam206
approved these changes
May 5, 2021
jwoo-msft
approved these changes
May 5, 2021
| @@ -0,0 +1,225 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: it would be great to have a screenshot of this for UWP.
There was a problem hiding this comment.
Screenshot's not going to help too much here as the interesting behavior is in the tooltips and the accessibility text, neither of which will be captured by that. Maybe I can update the card to better describe the expected behavior for each case.
jonmill
approved these changes
May 5, 2021
added 4 commits
May 5, 2021 12:03
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [UWP] Add rendering support for tooltip property * [iOS] added TooltipTestCard.json to a exclusion list for parsing & rendering test since the feature isn't developed for iOS * Add SAL * Add better descriptions to test card Co-authored-by: nesalang <Joseph.Woo@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [UWP] Add rendering support for tooltip property * [iOS] added TooltipTestCard.json to a exclusion list for parsing & rendering test since the feature isn't developed for iOS * Add SAL * Add better descriptions to test card Co-authored-by: nesalang <Joseph.Woo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5470
Description
Implemented UWP support for tooltips. Added logic to handle correctly setting the title and tooltip properties to the UI tooltip and automation name and description. Refactored automation name/description setting and tooltip creation for easier code sharing.
This PR does not fix related issue #5579. This means that container contents of a container are still not read in the case where the title is not present.
Sample Card
Added new card at samples\v1.5\Test\TooltipTestCard.json
How Verified
Using the above test card:
Microsoft Reviewers: Open in CodeFlow