Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Accessibility] Updated Expense report sample to fix contrast issue #5768

Merged
merged 4 commits into from
May 5, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented May 4, 2021

Related Issue

Fixes ADO 31604649

Description

The expense report card was explicitly setting the text color of the link text. This caused the link color to not adjust for high contrast. Removed the explicit setting of color on that link.

Sample Card

ExpenseReport.json
ExpenseReportWithLabels.json
ExpenseReport.template.json
ExpenseReportWithLabels.template.json

How Verified

Confirmed that the link now respects high contrast mode.

Microsoft Reviewers: Open in CodeFlow

@RebeccaAnne RebeccaAnne enabled auto-merge (squash) May 5, 2021 21:15
@RebeccaAnne RebeccaAnne merged commit f85e5a5 into main May 5, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/expensereportcontrast branch May 5, 2021 21:52
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants