Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Honour IconSize when horizontally aligned #5770

Merged
merged 3 commits into from
May 6, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented May 4, 2021

Related Issue

Fixes #5744

Description

Changes horizontal sizing for action icons case to match the vertical one by setting the size to match the "iconSize" property defined in the host config

Sample Card

  • Action.IconUrl.TwoActions.json

How Verified

Using the SampleApp the host config was modified to include "iconSize": 50, then using the aforementioned card we could inspect the result

image

Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms merged commit 7e75d44 into main May 6, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/Action_HonourIconSize branch May 6, 2021 17:52
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rendering][UWP] HostConfig iconSize not always honored
2 participants