[Android] Action.tooltip support #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
requested changes
May 10, 2021
| @@ -282,6 +282,17 @@ public void afterTextChanged(Editable s) | |||
| inlineButton.setPadding(16, 0, 0, 8); | |||
| } | |||
|
|
|||
| String contentDescription = !TextUtils.isEmpty(action.GetTitle()) ? action.GetTitle() : action.GetTooltip(); | |||
| String tooltip = !TextUtils.isEmpty(action.GetTooltip()) ? action.GetTooltip() : action.GetTitle(); | |||
| if (!TextUtils.isEmpty(tooltip)) | |||
|
|
||
| String contentDescription = !TextUtils.isEmpty(selectAction.GetTitle()) ? selectAction.GetTitle() : selectAction.GetTooltip(); | ||
| String tooltip = !TextUtils.isEmpty(selectAction.GetTooltip()) ? selectAction.GetTooltip() : selectAction.GetTitle(); | ||
| if (!TextUtils.isEmpty(tooltip)) |
Comment on lines
232
to
242
|
|
||
| String contentDescription = !TextUtils.isEmpty(selectAction.GetTitle()) ? selectAction.GetTitle() : selectAction.GetTooltip(); | ||
| String tooltip = !TextUtils.isEmpty(selectAction.GetTooltip()) ? selectAction.GetTooltip() : selectAction.GetTitle(); | ||
| if (!TextUtils.isEmpty(tooltip)) | ||
| { | ||
| view.setContentDescription(contentDescription); | ||
| } | ||
| if (!TextUtils.isEmpty(tooltip)) | ||
| { | ||
| TooltipCompat.setTooltipText(view, tooltip); | ||
| } |
There was a problem hiding this comment.
feels like this should probably be pulled out into a helper function
ghost
added
the
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [Android] Action.tooltip support * PR feedback
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [Android] Action.tooltip support * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5469
Description
Implement support for Action.tooltip. Additionally, previous implementation was not setting Action.title as accessible name when applied to a
selectActionor an icon-onlineinlineAction. That is now fixed.Sample Card
v1.5\Tests\TooltipTestCard.jsonHow Verified
Manual verification with Talkback
Microsoft Reviewers: Open in CodeFlow