[Android] Icon downloaded and displayed for overflow Action #5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootLevelActions added to onDisplayMenuAction callback.
robin-liao
approved these changes
May 11, 2021
golddove
approved these changes
May 11, 2021
| * @param view Overflow action view. | ||
| * @param menuItemList list of view of rendered secondary action elements. | ||
| * @param view Overflow action view. | ||
| * @param isRootLevelActions indicates action is part of root level actions or action set elements in body. |
There was a problem hiding this comment.
Suggested change
| * @param isRootLevelActions indicates action is part of root level actions or action set elements in body. | |
| * @param isRootLevelActions true if action is defined at root level, false if part of ActionSet |
Comment on lines
89
to
106
| if (!iconUrl.isEmpty()) | ||
| { | ||
| dropDownItem.post(() -> | ||
| IconPlacement iconPlacement = hostConfig.GetActions().getIconPlacement(); | ||
| if (!renderArgs.getAllowAboveTitleIconPlacement()) | ||
| { | ||
| Drawable[] drawables = button.getCompoundDrawablesRelative(); | ||
| dropDownItem.setCompoundDrawablePadding(button.getCompoundDrawablePadding()); | ||
| dropDownItem.setCompoundDrawablesRelativeWithIntrinsicBounds(drawables[0], drawables[1], drawables[2], drawables[3]); | ||
| }); | ||
| iconPlacement = IconPlacement.LeftOfTitle; | ||
| } | ||
|
|
||
| ActionElementRendererIconImageLoaderAsync imageLoader = new ActionElementRendererIconImageLoaderAsync( | ||
| renderedCard, | ||
| dropDownItem, | ||
| hostConfig.GetImageBaseUrl(), | ||
| iconPlacement, | ||
| hostConfig.GetActions().getIconSize(), | ||
| hostConfig.GetSpacing().getDefaultSpacing(), | ||
| context | ||
| ); | ||
| imageLoader.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR, iconUrl); |
There was a problem hiding this comment.
I believe this is identical to code in ActionElementRenderer. Consider moving it into a helper within ActionElementRenderer and calling it, instead of duplicating.
There was a problem hiding this comment.
moved to helper class.
golddove
changed the title
karthikgopal36
deleted the
bug/ActionOverflow/fix_overflow_dropdown_icon_issue
branch
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…t#5809) * Icon downloaded and displayed for DropdownItem. rootLevelActions added to onDisplayMenuAction callback. * Image loading functionality moved to helper class.
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…t#5809) * Icon downloaded and displayed for DropdownItem. rootLevelActions added to onDisplayMenuAction callback. * Image loading functionality moved to helper class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To display icon on a dropdown item, we usually fetch it from rendered action element and this works only when the dropdown item added to window. Otherwise, icon will not be displayed.
In this PR, we downloaded icon for dropdown item separately instead of fetching it from rendered action element, so the icon can be fetched and displayed on any condition.
Also, rootLevelActions flag added to the
onDisplayOverflowActionMenu()callback to distinguish betweenAction & ActionSetMicrosoft Reviewers: Open in CodeFlow