Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add AncestorHasSelectAction flag to RenderArgs #5838

Merged
merged 2 commits into from
May 27, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented May 18, 2021

Related Issue

Fixes #5603

Description

Add a AncestorHasSelectionFlag to allow developers know if any ancestor has a select action

Sample Card

If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.

How Verified

The fix was verified by adding tests covering all container scenarios to verify default and set to true behaviours

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. I don't see the render arg changes for card level selection action

* Set true to indicate an {@link io.adaptivecards.objectmodel.Container}, {@link io.adaptivecards.objectmodel.Column} or {@link io.adaptivecards.objectmodel.ColumnSet}
* elements have a select action.
*
* @param ancestorHasSelectAction true for root level action otherwise false.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@param description needs change

@ghost ghost added the no-recent-activity label May 24, 2021
@ghost
Copy link

ghost commented May 24, 2021

Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness.

@almedina-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@almedina-ms
Copy link
Contributor Author

/azp run "AdaptiveCards-SharedModel-CI" "AdaptiveCards-SharedModel-CI (Build & Test x64,Release)"

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@almedina-ms
Copy link
Contributor Author

/azp run AdaptiveCards-SharedModel-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@almedina-ms almedina-ms merged commit ba77796 into main May 27, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/Android_AncestorHasSelectAction branch May 27, 2021 22:22
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants