-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Add AncestorHasSelectAction flag to RenderArgs #5838
[Android] Add AncestorHasSelectAction flag to RenderArgs #5838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. I don't see the render arg changes for card level selection action
* Set true to indicate an {@link io.adaptivecards.objectmodel.Container}, {@link io.adaptivecards.objectmodel.Column} or {@link io.adaptivecards.objectmodel.ColumnSet} | ||
* elements have a select action. | ||
* | ||
* @param ancestorHasSelectAction true for root level action otherwise false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@param description needs change
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run "AdaptiveCards-SharedModel-CI" "AdaptiveCards-SharedModel-CI (Build & Test x64,Release)" |
No pipelines are associated with this pull request. |
/azp run AdaptiveCards-SharedModel-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issue
Fixes #5603
Description
Add a AncestorHasSelectionFlag to allow developers know if any ancestor has a select action
Sample Card
If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.
How Verified
The fix was verified by adding tests covering all container scenarios to verify default and set to
true
behavioursMicrosoft Reviewers: Open in CodeFlow