Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactnative/release 2.2.8 #5858

Merged
merged 4 commits into from
May 21, 2021
Merged

Reactnative/release 2.2.8 #5858

merged 4 commits into from
May 21, 2021

Conversation

IbrahimSulai
Copy link
Contributor

@IbrahimSulai IbrahimSulai commented May 21, 2021

This PR consist of the below features and bug fixes:

  1. Resolved the keyboard position issue in Android.
  2. isEnable feature is implemented as per schema.
  3. We have handled the Input.Toggle element position as same as Native platforms behaviour
  4. Bottom of the screen not Visible in Android - Scroll issue is resolved
  5. The page scroll issue in the show card feature is resolved
  6. Resolved the flickering issue in the date time picker dialog in the android.
Microsoft Reviewers: Open in CodeFlow

IbrahimSulai and others added 3 commits May 4, 2021 17:08
…5760)

* Updated the alignment of toggle input as same as native platform

* Handled isEnabled property for action type, select action and inline action

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
* Fixed Configmanager issues in ActionShowCard

* Fixed scroll issue and keyboard issue

* Fixed the date issue
Copy link
Contributor

@vivekvijayakrishnan vivekvijayakrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IbrahimSulai IbrahimSulai merged commit f5ce7e6 into main May 21, 2021
@IbrahimSulai IbrahimSulai deleted the reactnative/release-2.2.8 branch May 21, 2021 15:09
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Toggle input alignment and Handle isEnable property for action type (microsoft#5760)

* Updated the alignment of toggle input as same as native platform

* Handled isEnabled property for action type, select action and inline action

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>

* Reactnative/android bug fixes (microsoft#5783)

* Fixed Configmanager issues in ActionShowCard

* Fixed scroll issue and keyboard issue

* Fixed the date issue

* Fixed double rendering of DateTime picker control in android (microsoft#5811)

Co-authored-by: Ibrahim Sulaiman <ibrahim.sulaiman@imaginea.com>
Co-authored-by: Vivek Kozhisseri <vivekvijayakrishnan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants