Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Unpin Newtonsoft.JSON version #5959

Merged
merged 3 commits into from
Jun 10, 2021
Merged

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Jun 2, 2021

Related Issue

Fixes #5575

Description

With the current versioning regime, clients of our .NET libraries aren't allowed to use Newtonsoft.Json 13.x.

How Verified

  • local build, manual smoke test
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Hi @paulcam206. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Hi @paulcam206; Thanks for taking action on your previously stale pull request. Resetting staleness.

@jwoo-msft jwoo-msft disabled auto-merge June 10, 2021 19:06
@jwoo-msft jwoo-msft merged commit c88cd8e into main Jun 10, 2021
@jwoo-msft jwoo-msft deleted the paulcam/dotnet-newtonsoft-deps branch June 10, 2021 19:06
jwoo-msft added a commit that referenced this pull request Jun 11, 2021
paulcam206 added a commit that referenced this pull request Aug 19, 2021
Fixes #5575

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
(cherry picked from commit c88cd8e)
jonmill pushed a commit that referenced this pull request Aug 25, 2021
Fixes #5575

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
(cherry picked from commit c88cd8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[.Net] Newtonsoft.Json 13.0.1 (latest) version explicitly not supported
2 participants