Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Table implementation #5961

Merged
merged 7 commits into from
Jun 14, 2021
Merged

[UWP] Table implementation #5961

merged 7 commits into from
Jun 14, 2021

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Jun 2, 2021

Related Issue

Fixes #5726

Description

Added implementation of table rendering to UWP.

Sample Card

Validated against existing Table.json and added the following per-property table sample cards:
Table.FirstRowAsHeaders.json
Table.GridStyle.json
Table.HorizontalCellContentAlignment.json
Table.ShowGridLines.json
Table.VerticalCellContentAlignment.json

How Verified

Ran shared model and UWP unit tests and validated expected behavior against sample cards.

Microsoft Reviewers: Open in CodeFlow

samples/v1.5/Elements/Table.FirstRowAsHeaders.json Outdated Show resolved Hide resolved
source/uwp/Renderer/lib/Util.cpp Outdated Show resolved Hide resolved
source/uwp/Renderer/lib/XamlHelpers.h Outdated Show resolved Hide resolved
@RebeccaAnne RebeccaAnne enabled auto-merge (squash) June 3, 2021 22:04
@ghost ghost added the no-recent-activity label Jun 10, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jun 14, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@RebeccaAnne RebeccaAnne merged commit a89cca7 into main Jun 14, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/uwptablerender branch June 14, 2021 17:12
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* [UWP] Table implementation

* Spacing fixes

* another spacing fix

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* [UWP] Table implementation

* Spacing fixes

* another spacing fix

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UWP] Table Implementation
3 participants