-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UWP] Table implementation #5961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Jun 2, 2021
ghost
added
the
no-recent-activity
label
Jun 10, 2021
Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
ghost
removed
the
no-recent-activity
label
Jun 14, 2021
Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness. |
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* [UWP] Table implementation * Spacing fixes * another spacing fix Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* [UWP] Table implementation * Spacing fixes * another spacing fix Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5726
Description
Added implementation of table rendering to UWP.
Sample Card
Validated against existing Table.json and added the following per-property table sample cards:
Table.FirstRowAsHeaders.json
Table.GridStyle.json
Table.HorizontalCellContentAlignment.json
Table.ShowGridLines.json
Table.VerticalCellContentAlignment.json
How Verified
Ran shared model and UWP unit tests and validated expected behavior against sample cards.
Microsoft Reviewers: Open in CodeFlow