[iOS] updated intrinsic content size for UICollectionView #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Jun 11, 2021
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRImageSetUICollectionView.mm
Outdated
Show resolved
Hide resolved
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
…5993) * [iOS] updated intrinsic content size for UICollectionView * [iOS] addressed the review comments
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…5993) * [iOS] updated intrinsic content size for UICollectionView * [iOS] addressed the review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Image collection view returns zero intrinsic content size when the super view's width is zero.
Description
iOS AdaptiveCards width constraint is no longer required, and the intrinsic content size can be zero because of that. This PR returns the intrinsic content size as if all images are laid in a single row if the width is not yet determined. When the width is determined, a new intrinsic content size is calculated and ask for the layout engine to update the layout.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/ImageSet.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Scenarios/ImageGallery.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Scenarios/Agenda.json
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow