[JS] Updated deprecated usage of keycode to code (#5837)

[ghost]

Related Issue

Fixes #5837

Description

It has been identified that at various locations the deprecated keycode property was in use. This has been updated to use the code property instead.

How Verified

1. Built locally
2. Tested key commands on image element with select action
3. Tested key commands on media element

Microsoft Reviewers: Open in CodeFlow

[ghost]

Hi @ChristoperHowell. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

[ghost]

All CLA requirements met.

[paulcam206]

Thanks for the PR, @ChristoperHowell 👍

Taking a look now :)

[paulcam206]

looks good -- @dclaux?

[dclaux]

Looks good, but there are more uses of code in the designer code base that should also be updated (technically there are quite a few more in the adaptivecards-controls package as well but it's less important to update at this time)

[ghost]

Hi, @dclaux. I originally searched for keycode using VS code. This is what came back and I have fixed them. Would you be able to point me in the right direction to find more occurrences?

[dclaux]

@ChristoperHowell the other references are in the designer code base, which lives in the source\nodejs\adaptivecards-designer folder.

[ghost]

Thanks for the reply @dclaux. I’ve manually checked every file in the designer project and can find no other occurrences of the deprecated key code property.

From my understanding, the original issue requested that all occurrences of the deprecated key code property be updated to use the code property, which I have done this. Was there an additional requirement, or did I make a mistake in my understanding of this request? I can find other event properties being used such as the event shift key property. Would you like these modified to use the event code property?

Thanks for the input!

[dclaux]

@ChristoperHowell my apologies. I do not know what I typed in the search box, but I must have typed something else than "keyCode", as I'm now not finding the references I mentioned before. Or maybe I just dreamt them.

Either way, your changes look good, so I'll go ahead and approve your PR then merge.

Thank you very much for this contribution!

[ghost]

@dclaux, not a problem! Thanks for letting me contribute!