Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Designer] Fix contrast ratios for button borders #6007

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Jun 15, 2021

Related Issue

Fixes ADO 30642435 and 30926378

Description

Darken the border of buttons in order to meet accessibility contrast ratio requirements. Contrast ratio between background and button border is now 3.366:1

How Verified

Confirmed contrast ratio of buttons in the designer using accessibility insights.

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jun 15, 2021

Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@RebeccaAnne RebeccaAnne added this to the 21.06 milestone Jun 15, 2021
@ghost ghost added the no-recent-activity label Jun 21, 2021
@ghost
Copy link

ghost commented Jun 21, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jul 1, 2021
@ghost
Copy link

ghost commented Jul 1, 2021

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@almedina-ms
Copy link
Contributor

/azp run AdaptiveCards-iOS-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the no-recent-activity label Jul 7, 2021
@ghost
Copy link

ghost commented Jul 7, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jul 19, 2021
@ghost
Copy link

ghost commented Jul 19, 2021

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@ghost ghost added the no-recent-activity label Jul 24, 2021
@ghost
Copy link

ghost commented Jul 24, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@jonmill jonmill added this to Committed in Triage Aug 20, 2021
@jonmill jonmill removed this from Committed in Triage Aug 20, 2021
@ghost ghost removed the no-recent-activity label Sep 7, 2021
@ghost
Copy link

ghost commented Sep 7, 2021

Staleness reset by paulcam206

@ghost ghost added the no-recent-activity label Sep 12, 2021
@ghost
Copy link

ghost commented Sep 12, 2021

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Sep 14, 2021
@ghost
Copy link

ghost commented Sep 14, 2021

Staleness reset by almedina-ms

@RebeccaAnne RebeccaAnne merged commit 4aa4651 into main Sep 15, 2021
@RebeccaAnne RebeccaAnne deleted the rebecch/contrast branch September 15, 2021 20:46
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants