Jwoo/ios compact style update #6020
Conversation
…AdaptiveCards into jwoo/ios-compact-style-update
ghost
added
the
|
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @jwoo-msft; Thanks for taking action on your previously stale pull request. Resetting staleness. |
| - (void)testCanSetShowFilterListViewControlState | ||
| { | ||
| ACOFilteredListStateManager *stateManager = [[ACOFilteredListStateManager alloc] init]; | ||
| [stateManager expanded]; | ||
| XCTAssertTrue(stateManager.isShowFilteredListControlSelected); | ||
| [stateManager collapsed]; | ||
| XCTAssertFalse(stateManager.isShowFilteredListControlSelected); | ||
| } | ||
|
|
||
| - (void)testShowFilterListViewControlState | ||
| { | ||
| ACOFilteredListStateManager *stateManager = [[ACOFilteredListStateManager alloc] init]; | ||
| [stateManager expanded]; | ||
| XCTAssertTrue(stateManager.isShowFilteredListControlSelected); | ||
| [stateManager collapsed]; | ||
| XCTAssertFalse(stateManager.isShowFilteredListControlSelected); | ||
| } |
There was a problem hiding this comment.
Are these tests intended to be identical?
There was a problem hiding this comment.
thanks, it must have been added after a refactoring.
| return _showFilstedListControlState; | ||
| } | ||
|
|
||
| - (void)expanded |
There was a problem hiding this comment.
| - (void)expanded | |
| - (void)expand |
There was a problem hiding this comment.
thanks for the suggestion. the state manager merely keeps the state. so it is letting the state manager know that the state has changed.
| _showFilstedListControlState = YES; | ||
| } | ||
|
|
||
| - (void)collapsed |
There was a problem hiding this comment.
| - (void)collapsed | |
| - (void)collapse |
|
|
||
| CGFloat x = (viewController.view.superview) ? [viewController.view.superview convertPoint:self.frame.origin toView:nil].x : 0; | ||
| CGPoint inputPosition = [self convertPoint:self.frame.origin toView:_rootView]; | ||
| CGRect rootViewFrame = [self.superview convertRect:_rootView.frame toView:nil]; |
There was a problem hiding this comment.
I'm not following this series of calculation - is the goal to place the list to fill up the entire window?
There was a problem hiding this comment.
yes, I borrowed it from FluentUI logic. depending on where the input field is, FulentUI's control fills the entire screen starting from the input field.
| "id": "myColor1", | ||
| "style": "compact", | ||
| "isMultiSelect": false, | ||
| "placeholder": "Please choose", |
There was a problem hiding this comment.
Spaces should be tabs. Also, question - is placeholder going to work with filtered choiceset?
There was a problem hiding this comment.
it's part of the test sample files that's is local to iOS unit tests.
yes, place holder does work.
…AdaptiveCards into jwoo/ios-compact-style-update
* [iOS] implemented static filtering * [iOS] integrated shared model changes * [iOS] added text wrap support * [iOS] Added filtering to default value * [iOS] refactored and added unit test for static filtering
* [iOS] implemented static filtering * [iOS] integrated shared model changes * [iOS] added text wrap support * [iOS] Added filtering to default value * [iOS] refactored and added unit test for static filtering
Related Issue
fixed #5985
Description
Implemented static filtering for choiceset compact style
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Elements/Input.ChoiceSet.Filtered.json
How Verified
Microsoft Reviewers: Open in CodeFlow
ezgif.com-gif-maker.2.mov