-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Update project to support unit tests #6036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
changed the title
User/almedina ms/i os unit test base
[iOS] Update project to support unit tests
Jun 28, 2021
jwoo-msft
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@almedina-ms,
I've run your unit tests, and they didn't compile. To reproduce, in XCode, you can switch the scheme from the ADCIOSVisualizer to AdaptiveCards and compile.
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCardsTests/AdaptiveCardsTextBlockTests.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCardsTests/AdaptiveCardsTextBlockTests.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCardsTests/AdaptiveCardsTextBlockTests.mm
Outdated
Show resolved
Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCardsTests/AdaptiveCardsTextBlockTests.mm
Outdated
Show resolved
Hide resolved
ghost
added
the
Needs: Author Feedback
label
Jun 30, 2021
…oft/AdaptiveCards into user/almedina-ms/iOS_UnitTestBase
ghost
removed
the
Needs: Author Feedback
label
Jul 1, 2021
@almedina-ms, |
jwoo-msft
approved these changes
Jul 2, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Add base for ios unit test * Fix build errors and PR comments * [iOS] fixed compilation issue for unit test (microsoft#6044) Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add base for ios unit test * Fix build errors and PR comments * [iOS] fixed compilation issue for unit test (microsoft#6044) Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6030
Description
TO DO: Update CI pipeline to run unit tests
How Verified
Tests were run
Microsoft Reviewers: Open in CodeFlow