Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Update project to support unit tests #6036

Merged
merged 7 commits into from
Jul 2, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Jun 25, 2021

Related Issue

Fixes #6030

Description

  • Adds unit tests files to the ios AdaptiveCards project
  • Adds two sample tests to verify the tests are executed

TO DO: Update CI pipeline to run unit tests

How Verified

Tests were run

Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms changed the title User/almedina ms/i os unit test base [iOS] Update project to support unit tests Jun 28, 2021
Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almedina-ms,
I've run your unit tests, and they didn't compile. To reproduce, in XCode, you can switch the scheme from the ADCIOSVisualizer to AdaptiveCards and compile.

@ghost ghost removed the Needs: Author Feedback label Jul 1, 2021
@jwoo-msft
Copy link
Member

@almedina-ms,
can you check this PR, #6044?
This should fix the compilation issue.

@almedina-ms almedina-ms enabled auto-merge (squash) July 1, 2021 21:31
@almedina-ms almedina-ms merged commit 42031bb into main Jul 2, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/iOS_UnitTestBase branch July 2, 2021 04:43
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* Add base for ios unit test

* Fix build errors and PR comments

* [iOS] fixed compilation issue for unit test (microsoft#6044)

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Add base for ios unit test

* Fix build errors and PR comments

* [iOS] fixed compilation issue for unit test (microsoft#6044)

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Set up Unit tests support
2 participants