[UWP] Split the UWP object model from the renderer #6067
Conversation
ghost
added
the
|
Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. In reply to: 879362616 |
|
Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness. In reply to: 882698973 |
| <ClCompile Include="lib\AdaptiveTableRow.cpp" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ClInclude Include="lib\AdaptiveCard.h" /> |
There was a problem hiding this comment.
why are some of these files duplicated?
There was a problem hiding this comment.
Which ones are dups? I'm not noticing them.
| @@ -17,7 +17,7 @@ namespace AdaptiveCards | |||
| static InternalId Current(); | |||
| static constexpr unsigned int Invalid = 0; | |||
|
|
|||
| std::size_t Hash() const { return std::hash<unsigned int>()(m_internalId); } | |||
There was a problem hiding this comment.
why is this change being done?
There was a problem hiding this comment.
The instigating change here was that i needed to expose internal id out of the public API surface and i declared it as UINT32. When you build this for x64 you get errors assigning tying to assign a (64 bit) size_t to a UINT32, whereas a (32bit) unsigned int (which is what we're storing it in anyway) works fine.
I removed the std::hash call because (a) it returned size_t and (b) the hash of the integer is itself. That said, I admit there might be a good reason to do this that i'm not aware of. @paulcam206 is there a reason this is a Bad Idea?
source/uwp/AdaptiveCardsObjectModel/lib/AdaptiveActionParserRegistration.cpp
Show resolved
Hide resolved
source/uwp/AdaptiveCardsObjectModel/lib/AdaptiveImageParser.cpp
Outdated
Show resolved
Hide resolved
|
Removed In reply to: 715106367 |
|
I saw this on my main GitHub home activity feed, awesome to see this happen! Always wished the UWP object model and renderer was split like this! ❤️ |
* [UWP] Split the UWP object model from the renderer * build break fix * PR feedback * Removed unneeded file and update .gitignore to ignore generated header * delete generated header * More cleanup * Add InternalId.h to the project
* [UWP] Split the UWP object model from the renderer * build break fix * PR feedback * Removed unneeded file and update .gitignore to ignore generated header * delete generated header * More cleanup * Add InternalId.h to the project
Related Issue
Fixes: #5885
Description
Separated the Object Model portion of the UWP renderer into a separate library that can be consumed independently of the main renderer component. The object model has been moved from the AdaptiveCards.Rendering.Uwp namespace to the AdaptiveCards.ObjectModel.Uwp namespace. This involved pulling all object model interface definitions/code/utilities into a new library. Downstream changes to make sure everything still builds/works include
How Verified
Microsoft Reviewers: Open in CodeFlow