Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure][Accessibility] Add CI check for web accessibility insights #6070

Merged
merged 16 commits into from
Aug 9, 2021

Conversation

golddove
Copy link
Member

@golddove golddove commented Jul 8, 2021

Related Issue

Fixes #6069

Description

Add Github workflow that runs daily accessibility insights scan on the CI endpoint

Sample Card

N/A

How Verified

Manual verification

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Jul 13, 2021
@ghost
Copy link

ghost commented Jul 13, 2021

Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jul 14, 2021
@ghost
Copy link

ghost commented Jul 14, 2021

Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness.

@github-actions
Copy link

github-actions bot commented Jul 14, 2021

Accessibility Insights Accessibility Insights Action

  • URLs: 26 URL(s) failed, 0 URL(s) passed, and 0 were not scannable
  • Rules: 67 check(s) failed, 21 check(s) passed, and 26 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

Failed instances

  • 2 × color-contrast: Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds
  • 41 × image-alt: Ensures elements have alternate text or a role of none or presentation
  • 12 × aria-required-attr: Ensures elements with ARIA roles have all required ARIA attributes
  • 8 × label: Ensures every form element has a label
  • 2 × aria-required-children: Ensures elements with an ARIA role that require child roles contain them
  • 2 × select-name: Ensures select element has an accessible name

This scan used axe-core 4.2.1 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@ghost ghost added the no-recent-activity label Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness.

@golddove golddove marked this pull request as ready for review August 6, 2021 16:12
@golddove golddove enabled auto-merge (squash) August 9, 2021 17:14
@golddove golddove merged commit c23feea into main Aug 9, 2021
@golddove golddove deleted the golddove/6069 branch August 9, 2021 17:23
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
…sights (microsoft#6070)

* [Infrastructure][Accessibility] Add CI check for web accessibility insights

* Pass repo token

* Limit scanning

* Limit to samples

* Wait until JS pipeline

* Syntax

* Pin full SHA, as recommended

* Try trigger on check instead

* Daily-only

* Allow manual dispatch

* Newline

* Rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add daily scan for web accessibility insights
2 participants