Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added designer feedback button link to the GitHub designer issue template #6090

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Added designer feedback button link to the GitHub designer issue template #6090

merged 4 commits into from
Jul 26, 2021

Conversation

rahulamlekar
Copy link
Contributor

@rahulamlekar rahulamlekar commented Jul 14, 2021 •
edited by ghost

Related Issue

Fixes #6021

Description

Clicking designer feedback button now links to the GitHub designer issue template

How Verified

Verified to open the following page
image

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Jul 14, 2021

Hi @rahulamlekar. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@rahulamlekar rahulamlekar enabled auto-merge (squash) July 14, 2021 17:40
@ghost ghost added the no-recent-activity label Jul 19, 2021
@ghost
Copy link

ghost commented Jul 19, 2021

Hi @rahulamlekar. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Hi @rahulamlekar; Thanks for taking action on your previously stale pull request. Resetting staleness.

@ghost ghost added the no-recent-activity label Jul 26, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

Hi @rahulamlekar. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Jul 26, 2021
@ghost
Copy link

ghost commented Jul 26, 2021

Hi @rahulamlekar; Thanks for taking action on your previously stale pull request. Resetting staleness.

@rahulamlekar rahulamlekar requested a review from dclaux July 26, 2021 18:17
golddove
golddove approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@golddove golddove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate that Github doesn't automatically use the tags/title from template configuration

@rahulamlekar rahulamlekar merged commit d9b8953 into main Jul 26, 2021
@rahulamlekar rahulamlekar deleted the designerIssue branch July 26, 2021 21:05
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@rahulamlekar @michaelfarnsworth
Clicking designer feedback button now links to the GitHub designer is…
8468e82 
…sue template (microsoft#6090)

Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golddove golddove golddove approved these changes

@dclaux dclaux Awaiting requested review from dclaux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Designer] Feedback button on designer should link to the "Designer Bug Report" issue type
2 participants
@rahulamlekar @golddove