Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Modifications to iOS test app for UI testing #6094

Merged
merged 11 commits into from
Aug 17, 2021
Merged

[iOS] Modifications to iOS test app for UI testing #6094

merged 11 commits into from
Aug 17, 2021

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Jul 16, 2021 •
edited

Related Issue

Fixes #5923

Description

  • Updates the iOS app to handle a parameter to check if it's on testing mode
  • Adds a label control to contain the retrieved inputs
  • Adds 3 tests to run basic scenarios of AdaptiveCards

How Verified

This change includes unit tests so it was verified by checking the test success

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Jul 21, 2021
@ghost
Copy link

ghost commented Jul 21, 2021 •
edited by almedina-ms

Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

In reply to: 884460303

In reply to: 884460303

In reply to: 884460303

In reply to: 884460303

In reply to: 884460303

@ghost ghost removed the no-recent-activity label Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021 •
edited by almedina-ms

Staleness reset by golddove

In reply to: 885052808

In reply to: 885052808

In reply to: 885052808

In reply to: 885052808

In reply to: 885052808

In reply to: 885052808

@ghost
Copy link

ghost commented Jul 22, 2021 •
edited by almedina-ms

Staleness reset by golddove

In reply to: 885052841

In reply to: 885052841

In reply to: 885052841

In reply to: 885052841

In reply to: 885052841

@ghost ghost added the no-recent-activity label Jul 27, 2021
@ghost
Copy link

ghost commented Jul 27, 2021 •
edited by almedina-ms

Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

In reply to: 887795411

In reply to: 887795411

In reply to: 887795411

In reply to: 887795411

@ghost ghost removed the no-recent-activity label Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021 •
edited by almedina-ms

Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness.

In reply to: 893912048

In reply to: 893912048

In reply to: 893912048

In reply to: 893912048

jwoo-msft
jwoo-msft reviewed Aug 6, 2021
View reviewed changes
Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to run the tests in ci pipeline?

jwoo-msft
jwoo-msft requested changes Aug 6, 2021
View reviewed changes
Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see a few small things that I would like to get changed.
but overall, it's a great change. I like your tests, and the tests scenarios are very thorough and have easy interfaces.
thanks!

source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerUITests/ADCIOSVisualizerUITests.mm Outdated Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerUITests/ADCIOSVisualizerUITests.mm
@@ -32,6 +38,156 @@ - (void)tearDown
[super tearDown];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to close test app as we launch the test app in setUp

source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizer/ViewController.m Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizer/ViewController.m Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizer/ViewController.m Outdated Show resolved Hide resolved
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRTextView.mm Outdated Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerUITests/ADCIOSVisualizerUITests.mm Outdated Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerUITests/ADCIOSVisualizerUITests.mm Outdated Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizerUITests/ADCIOSVisualizerUITests.mm Show resolved Hide resolved
source/ios/AdaptiveCards/ADCIOSVisualizer/ADCIOSVisualizer/ViewController.m Show resolved Hide resolved
@ghost
Copy link

ghost commented Aug 11, 2021 •
edited by almedina-ms

Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

In reply to: 897111848

In reply to: 897111848

@ghost ghost removed the no-recent-activity label Aug 11, 2021
@ghost
Copy link

ghost commented Aug 11, 2021 •
edited by almedina-ms

Staleness reset by almedina-ms

In reply to: 897173430

In reply to: 897173430

In reply to: 897173430

@ghost ghost removed the Needs: Author Feedback label Aug 11, 2021
@almedina-ms almedina-ms mentioned this pull request Aug 13, 2021
Closed
@almedina-ms almedina-ms merged commit 19bb652 into main Aug 17, 2021
@almedina-ms almedina-ms deleted the user/almedina-ms/iOS_UITestApp branch August 17, 2021 17:28
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@almedina-ms @michaelfarnsworth
[iOS] Modifications to iOS test app for UI testing (microsoft#6094)
8a01088 
* Add Label for displaying inputs

* Update test app for testing

* Add first set of tests

* Fix tests

* Fix broken test and resolve a comment

* Fix PR comments with memory leak

* Undo accessibility id and label changes as tests succeed without them

* Add warning for testing memory leak
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@almedina-ms
[iOS] Modifications to iOS test app for UI testing (microsoft#6094)
36cb670 
* Add Label for displaying inputs

* Update test app for testing

* Add first set of tests

* Fix tests

* Fix broken test and resolve a comment

* Fix PR comments with memory leak

* Undo accessibility id and label changes as tests succeed without them

* Add warning for testing memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoo-msft jwoo-msft jwoo-msft approved these changes

@golddove golddove golddove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Implement/Update basic test app for UI Tests
3 participants
@almedina-ms @jwoo-msft @golddove