Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixed #6082 #6158

Merged
merged 5 commits into from
Aug 6, 2021
Merged

[iOS] Fixed #6082 #6158

merged 5 commits into from
Aug 6, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Aug 3, 2021

Related Issue

Fixed #6082

Description

  1. Added button height and title width constraints to public interface to help custom styling.
  2. Added mocks to aid in current & future unit tests.

Sample Card

N/A

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests were added.
  2. All unit tests were run.
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft enabled auto-merge (squash) August 6, 2021 23:20
@jwoo-msft jwoo-msft merged commit 3bada37 into main Aug 6, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-button-update branch August 6, 2021 23:40
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
* [iOS] updated action test

* [iOS] Added vertical constraint to public API and mocks for unit testing

* [iOS] added title width constraint to public api
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* [iOS] updated action test

* [iOS] Added vertical constraint to public API and mocks for unit testing

* [iOS] added title width constraint to public api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rendering] [iOS] ACR button rendering Is wonky as the SDK sets up height constraint and so does the Teams app
3 participants