Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] fixed #4531 #6180

Merged
merged 3 commits into from
Aug 17, 2021
Merged

[iOS] fixed #4531 #6180

merged 3 commits into from
Aug 17, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Aug 10, 2021

Related Issue

Fixed #4531

Description

iOS sdk added underline to rich text block's select action. this change removes the link and applies default link color to match with the default presentation of the iOS link. The UIColor.link is applied when available, 13.0 above. If not available, the same hex value of the UIColor.link is used.

Sample Card

https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Tests/RichTextBlock.TextRun.SelectActions.json

How Verified

How you verified the fix, including one or all of the following:

  1. Unit tests are run
  2. sample cards are run

Select actions with default foreground color and custom colors.
Screen Shot 2021-08-10 at 10 31 52 AM

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft enabled auto-merge (squash) August 17, 2021 01:45
@ghost ghost added the no-recent-activity label Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@golddove
Copy link
Member

Android/JS seem to ignore foreground color for links in that same sample:

image

image

@ghost ghost removed the no-recent-activity label Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Hi @golddove; Thanks for commenting on this previously stale pull request. Resetting staleness. @jwoo-msft FYI.

@almedina-ms
Copy link
Contributor

As a general question, is there consensus around having actions in text without an underline?

@jwoo-msft
Copy link
Member Author

jwoo-msft commented Aug 17, 2021

As a general question, is there consensus around having actions in text without an underline?

we've decided in the design discussion that the format of link should match the platform's default style.

@jwoo-msft
Copy link
Member Author

Android/JS seem to ignore foreground color for links in that same sample:

image

image

will match android/js

@jwoo-msft jwoo-msft merged commit 171459e into main Aug 17, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-richTextBlock branch August 17, 2021 21:37
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][RichTextBlock Rendering] [Parity issue in RichTextBlock TextRun with action]
4 participants