-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] fixed #4531 #6180
[iOS] fixed #4531 #6180
Conversation
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Hi @golddove; Thanks for commenting on this previously stale pull request. Resetting staleness. @jwoo-msft FYI. |
As a general question, is there consensus around having actions in text without an underline? |
we've decided in the design discussion that the format of link should match the platform's default style. |
Related Issue
Fixed #4531
Description
iOS sdk added underline to rich text block's select action. this change removes the link and applies default link color to match with the default presentation of the iOS link. The UIColor.link is applied when available, 13.0 above. If not available, the same hex value of the UIColor.link is used.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Tests/RichTextBlock.TextRun.SelectActions.json
How Verified
How you verified the fix, including one or all of the following:
Select actions with default foreground color and custom colors.
Microsoft Reviewers: Open in CodeFlow