Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixed #5283 #6214

Merged
merged 8 commits into from
Aug 18, 2021
Merged

[iOS] Fixed #5283 #6214

merged 8 commits into from
Aug 18, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Aug 17, 2021 •
edited

Related Issue

Fixed #5283, Fixed #6207

Description

  • Changed font to use dynamic type.
  • If HTML is used for font, then font attribute is checked in the whole range of the text, and font is updated to use dynamic type.
  • Updated sample app to demonstrate the feature
    • Added ability to handle accessibility status change event
    • Changed to use automatic dimension in the UITableView to handle the accessibility status change event.
    • Refactored & cleaned up the codes
  • Bumped up minimum iOS version from 10 to 11

Sample Card

N/A

How Verified

How you verified the fix, including one or all of the following:

  1. Existing relevant unit/regression tests are run.
dynamicFontType.mov
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft enabled auto-merge (squash) August 17, 2021 01:43
@jwoo-msft jwoo-msft merged commit db157fc into main Aug 18, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-accessibility-font branch August 18, 2021 04:56
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@jwoo-msft @michaelfarnsworth
[iOS] Fixed microsoft#5283 (microsoft#6214)
b529726 
* [iOS] Fixed microsoft#5283

* Fixed unit test error
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft
[iOS] Fixed microsoft#5283 (microsoft#6214)
9d566b5 
* [iOS] Fixed microsoft#5283

* Fixed unit test error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

@almedina-ms almedina-ms almedina-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jwoo-msft @paulcam206 @almedina-ms