Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixed #6219, #6222 #6233

Merged
merged 5 commits into from
Aug 25, 2021
Merged

[iOS] Fixed #6219, #6222 #6233

merged 5 commits into from
Aug 25, 2021

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Aug 20, 2021 •
edited

Related Issue

Fixed #6219, Fixed #6222

Description

  • scaled background image view to the minimum size that can cover the target view.
  • simplified the logic for background image when its dimension is less than the target view.
  • refactored code
    • grouped constraints and activate them at once for better performance.
    • reduced priority for min-height to 999 from max as it interferes with background image height.

Sample Card

AdaptiveCard.BackgroundImage.FillMode.Cover.SmallImage.json

How Verified

How you verified the fix, including one or all of the following:

  1. New unit test is added
  2. Existing unit tests are tested
  3. Relavent sample cards are tested.
    Screen Shot 2021-08-20 at 2 58 27 PM

Screen Shot 2021-08-20 at 4 21 36 PM

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft changed the title [iOS] Fixed #6219 [iOS] Fixed #6219, #6222 Aug 20, 2021
@jonmill jonmill added this to P1 in Triage Aug 20, 2021
@jwoo-msft jwoo-msft enabled auto-merge (squash) August 20, 2021 23:30
@jonmill jonmill removed this from P1 in Triage Aug 20, 2021
almedina-ms
almedina-ms approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jwoo-msft jwoo-msft merged commit 3383b81 into main Aug 25, 2021
@jwoo-msft jwoo-msft deleted the jwoo/ios-background-image-update branch August 25, 2021 19:48
michaelfarnsworth pushed a commit to michaelfarnsworth/AdaptiveCards that referenced this pull request Nov 10, 2022
@jwoo-msft @michaelfarnsworth
[iOS] Fixed microsoft#6219, microsoft#6222 (microsoft#6233)
1043b63 
* [iOS] Fixed microsoft#6219

* Updated sample card

* [iOS] Fixes 6222
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft
[iOS] Fixed microsoft#6219, microsoft#6222 (microsoft#6233)
36cbd69 
* [iOS] Fixed microsoft#6219

* Updated sample card

* [iOS] Fixes 6222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

@almedina-ms almedina-ms almedina-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jwoo-msft @paulcam206 @almedina-ms