Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package.json fields for adaptivecards-react #6266

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix package.json fields for adaptivecards-react #6266

merged 1 commit into from
Aug 30, 2021

Conversation

marakim
Copy link
Contributor

@marakim marakim commented Aug 30, 2021 •
edited by ghost

Fix for some incorrect fields in package.json

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Aug 30, 2021

Hi @marakim. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

jonmill
jonmill approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@jonmill jonmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paulcam206
paulcam206 approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@paulcam206 paulcam206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jonmill jonmill enabled auto-merge (squash) August 30, 2021 18:51
@jonmill jonmill disabled auto-merge August 30, 2021 19:53
@jonmill jonmill merged commit a545f87 into microsoft:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmill jonmill jonmill approved these changes

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marakim @jonmill @paulcam206