[Android] Fix Markdown ordered lists to honour start #6310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
requested changes
Sep 3, 2021
ghost
added
the
…ithub.com/microsoft/AdaptiveCards into user/almedina-ms/Android_FixMDolNumbering
paulcam206
approved these changes
Sep 3, 2021
jwoo-msft
requested changes
Sep 8, 2021
source/android/adaptivecards/src/main/java/io/adaptivecards/renderer/readonly/RendererUtil.java
Show resolved
Hide resolved
jwoo-msft
approved these changes
Sep 13, 2021
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
* Working version with reflection * Add ContentHandler overrides and add tests * Fix handled code * Fix test break * Add more tests
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Working version with reflection * Add ContentHandler overrides and add tests * Fix handled code * Fix test break * Add more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #6238
Description
Context: In the Android rendered all texts to be rendered are preprocessed to convert the markdown components to HTML
In the android renderer, any text containing ". " is parsed as the start of an ordered markdown list, this approach works most of the time but due to some limitations the ordered lists would always start at 1 as we would miss context on the html tag attributes, for this reason this PR overrides the ContentHandler class behaviour inside of the currently used XMLReader to retrieve the attributes for any given html element and thus providing a correct starting number for any ordered list.
Sample Card
v1.5/Test/TextBlock.Markdown.NumberStart.json
How Verified
Microsoft Reviewers: Open in CodeFlow